Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for online remapping #2179

Merged
merged 23 commits into from
Dec 5, 2023
Merged

Add support for online remapping #2179

merged 23 commits into from
Dec 5, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Oct 2, 2023

This PR

  • Transforms writers to standalone objects instead of functions
  • Changes the diagnostics to have one writer for all the diagnostics
  • Adds support to a general NetCDF writer

This PR requires CliMA/ClimaCore.jl#1475 to be merged.

@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch 3 times, most recently from 89fe525 to d64fce1 Compare October 2, 2023 23:17
@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch 7 times, most recently from 46a0e91 to 18a3d2b Compare October 5, 2023 15:49
@Sbozzolo
Copy link
Member Author

Sbozzolo commented Oct 5, 2023

Topography available as diagnostic orog:

display

@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch 6 times, most recently from c434052 to 8184376 Compare October 10, 2023 22:15
@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch from 8184376 to 23f7c56 Compare October 11, 2023 00:02
@Sbozzolo
Copy link
Member Author

With CliMA/ClimaCore.jl#1497, this PR has full support for topography.

Example: z is from sea level (with wrong titles, level -> elevation from MSL )
rhoa_inst_1
z is from surface
rhoa_inst_1

@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch from 23f7c56 to 99db934 Compare October 11, 2023 22:17
@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch 5 times, most recently from ef9293c to c65f3ae Compare October 20, 2023 16:40
- Transform writers to standalone objects instead of functions
- Have one writer for all the diagnostics
- Add support to general NetCDF writer

Now with support for all the configurations (including planes ✈️)
Following the CF conventions
Bump the ref counter because some jobs are now run for longer
This commit introduces breaking changes in the interface.

* get_integrator is now replaced with get_simulation

The immediate reason for this change is that when we have diagnostics,
we also have a bunch of writers that open files and keep them open for
all the writing operations. We must ensure that the files are properly
closed at the end of the simulation. Hence, the integrator is no longer
enough. We could find a way to add this piece of information to the
cache, but now that the cache is more rigid, this becomes a pain.

In any case, we want to work on the atmos interface, especially for
coupler compatibility. At the moment, AtmosSimulation is a thin wrapper
that contains only the integrator at the writers. But this object will
extended to contain more useful and general information.

* simulation was removed from the cache

Now that simulation is its own object, it doesn't need to be in the
cache anymore
We currently print out when the allocations are lower than the hardcoded
limit, but we don't enforce changing this. This commit adds a second
test that fails when the measured allocations are fewer than 50 % of the
ones saved in the file
@Sbozzolo Sbozzolo force-pushed the gb/diagnostics_ready branch from 11278b5 to 91fe85c Compare December 4, 2023 23:16
@Sbozzolo Sbozzolo enabled auto-merge December 4, 2023 23:16
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 1c7d632 Dec 5, 2023
10 checks passed
@Sbozzolo Sbozzolo deleted the gb/diagnostics_ready branch December 5, 2023 01:11
@Sbozzolo Sbozzolo mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants