-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for online remapping #2179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
3 times, most recently
from
October 2, 2023 23:17
89fe525
to
d64fce1
Compare
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
7 times, most recently
from
October 5, 2023 15:49
46a0e91
to
18a3d2b
Compare
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
6 times, most recently
from
October 10, 2023 22:15
c434052
to
8184376
Compare
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
from
October 11, 2023 00:02
8184376
to
23f7c56
Compare
With CliMA/ClimaCore.jl#1497, this PR has full support for topography. Example: |
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
from
October 11, 2023 22:17
23f7c56
to
99db934
Compare
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
5 times, most recently
from
October 20, 2023 16:40
ef9293c
to
c65f3ae
Compare
- Transform writers to standalone objects instead of functions - Have one writer for all the diagnostics - Add support to general NetCDF writer Now with support for all the configurations (including planes✈️ )
Following the CF conventions
[skip ci]
[skip ci][ci skip]
[skip ci][ci skip]
Bump the ref counter because some jobs are now run for longer
This commit introduces breaking changes in the interface. * get_integrator is now replaced with get_simulation The immediate reason for this change is that when we have diagnostics, we also have a bunch of writers that open files and keep them open for all the writing operations. We must ensure that the files are properly closed at the end of the simulation. Hence, the integrator is no longer enough. We could find a way to add this piece of information to the cache, but now that the cache is more rigid, this becomes a pain. In any case, we want to work on the atmos interface, especially for coupler compatibility. At the moment, AtmosSimulation is a thin wrapper that contains only the integrator at the writers. But this object will extended to contain more useful and general information. * simulation was removed from the cache Now that simulation is its own object, it doesn't need to be in the cache anymore
We currently print out when the allocations are lower than the hardcoded limit, but we don't enforce changing this. This commit adds a second test that fails when the measured allocations are fewer than 50 % of the ones saved in the file
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
from
December 4, 2023 23:16
11278b5
to
91fe85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR requires CliMA/ClimaCore.jl#1475 to be merged.